Add the effective DOS and the energy band gap models#2640
Closed
damiano-flex wants to merge 9 commits into
Closed
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
709
to
715
| "set_logging_console", | ||
| "set_logging_file", | ||
| "wavelengths", | ||
| "ConstantEnergyBandGap", | ||
| "QuadraticEnergyBandGap", | ||
| "VarshniEnergyBandGap", | ||
| ] |
There was a problem hiding this comment.
style: consider grouping energy band gap models together with the other models in the first import block rather than appending to end of all
marc-flex
reviewed
Jul 9, 2025
Contributor
marc-flex
left a comment
marc-flex
left a comment
There was a problem hiding this comment.
This is great. Thanks @damiano-flex
|
|
||
| .. math:: | ||
|
|
||
| E_g(T) = E_g(300) + \\alpha T + \\beta T^2 |
Contributor
There was a problem hiding this comment.
Can you maybe add a dot between the constant and the T? I.e., \\alpha \\dot T
Comment on lines
+21
to
+22
| Models the temperature dependence of the energy band gap (Eg) using a | ||
| quadratic approximation. |
Contributor
There was a problem hiding this comment.
When I get home I'll give you a reference for this.
Comment on lines
+2031
to
+2033
| N_c=ConstantEffectiveDOS(N=2.86e19), | ||
| N_v=ConstantEffectiveDOS(N=3.1e19), | ||
| E_g=ConstantEnergyBandGap(eg=1.11), |
Contributor
There was a problem hiding this comment.
Maybe we can add the temperature-dependence models by default? Maybe we should first check that we get the same values at 300K, though
marc-flex
force-pushed
the
marc/non_isothermal
branch
from
11cd469 to
ddaaccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Refactors semiconductor material modeling by introducing modular DOS and band gap models, replacing hardcoded values with configurable model classes.
tidy3d/__init__.pyincludingConstantEffectiveDOS,IsotropicEffectiveDOS,MultiValleyEffectiveDOS, and various energy band gap modelsSemiconductorMediumincomponents/material/tcad/charge.pyto use model-based implementations forN_c,N_v, andE_gparametersmaterial_library/material_library.pyto use new model classes while preserving existing valuestest_heat_charge.pyto use the new model classes instead of hardcoded values